feat: add DataTable component (@fehmer) by fehmer · Pull Request #7397 · monkeytypegame/monkeytype

fehmer · 2026-01-20T00:59:57Z

following https://www.solid-ui.com/docs/components/data-table

socket-security · 2026-01-20T01:02:01Z

All alerts resolved. Learn more about Socket for GitHub.

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report

github-actions · 2026-01-23T12:08:34Z

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes.

Copilot

Pull request overview

Adds a SolidJS DataTable implementation based on TanStack Solid Table, including responsive column visibility and persistent sorting.

Changes:

Add @tanstack/solid-table dependency (and lockfile updates).
Introduce new DataTable, Table, and TableColumnHeader UI components.
Add TanStack table column meta typing (breakpoint + cell attributes) and export BreakpointKey for reuse.

Reviewed changes

Copilot reviewed 6 out of 8 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
pnpm-lock.yaml	Locks new TanStack table dependency and transitive updates.
frontend/package.json	Adds `@tanstack/solid-table` to frontend deps.
frontend/tsconfig.json	Adds an extra include entry for `.d.ts` (currently suspicious/redundant).
frontend/src/ts/types/tanstack-table.d.ts	Module augmentation for column meta (`breakpoint`, `cellMeta`).
frontend/src/ts/signals/breakpoints.ts	Exports `BreakpointKey` type for table column meta.
frontend/src/ts/components/ui/table/TableColumnHeader.tsx	New sortable column header button component.
frontend/src/ts/components/ui/table/Table.tsx	New styled table primitive components.
frontend/src/ts/components/ui/table/DataTable.tsx	New DataTable wiring sorting + responsive visibility + cell meta attributes.

Files not reviewed (1)

pnpm-lock.yaml: Language not supported

frontend/src/ts/components/ui/table/DataTable.tsx

frontend/src/ts/components/ui/table/TableColumnHeader.tsx

frontend/tsconfig.json

frontend/src/ts/components/ui/table/DataTable.tsx

github-actions · 2026-01-27T21:06:39Z

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes.

github-actions · 2026-01-27T23:09:08Z

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes.

github-actions · 2026-01-27T23:10:47Z

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes.

Copilot

Pull request overview

Copilot reviewed 5 out of 7 changed files in this pull request and generated 4 comments.

Files not reviewed (1)

pnpm-lock.yaml: Language not supported

frontend/src/ts/components/ui/table/DataTable.tsx

Copilot · 2026-01-28T20:50:08Z

frontend/src/ts/components/ui/table/DataTable.tsx

Sorting UI is gated on typeof columnDef.header === "string". If a sortable column provides a JSX/header renderer (common in TanStack), the column will be sortable in state but not clickable in the UI. Gate only on getCanSort() (and !header.isPlaceholder) and render the header label via flexRender(...) inside the button.

frontend/src/ts/components/ui/table/DataTable.tsx

monkeytypegeorge added the frontend User interface or web stuff label Jan 20, 2026

fehmer force-pushed the feature/data-table branch 3 times, most recently from d4cfd81 to 917e717 Compare January 23, 2026 12:05

fehmer marked this pull request as ready for review January 23, 2026 12:05

github-actions bot added the waiting for review Pull requests that require a review before continuing label Jan 23, 2026

fehmer force-pushed the feature/data-table branch from 0386015 to e307c44 Compare January 25, 2026 19:21

feat: add DataTable component (@fehmer)

1e10edb

fehmer force-pushed the feature/data-table branch from e307c44 to 1e10edb Compare January 26, 2026 11:36

Miodec requested a review from Copilot January 27, 2026 19:17

Copilot started reviewing on behalf of Miodec January 27, 2026 19:18 View session

github-actions bot added the waiting for review Pull requests that require a review before continuing label Jan 27, 2026

Copilot AI reviewed Jan 27, 2026

View reviewed changes

review comments

22a5284

github-actions bot added waiting for update Pull requests or issues that require changes/comments before continuing and removed waiting for review Pull requests that require a review before continuing labels Jan 27, 2026

fix gap on mouseover

fafdc95

github-actions bot removed the waiting for update Pull requests or issues that require changes/comments before continuing label Jan 27, 2026

cleanup

6b6a4d6

github-actions bot added waiting for update Pull requests or issues that require changes/comments before continuing and removed waiting for update Pull requests or issues that require changes/comments before continuing labels Jan 27, 2026

github-actions bot added the waiting for update Pull requests or issues that require changes/comments before continuing label Jan 27, 2026

fehmer added 2 commits January 28, 2026 00:14

copilot comments

5a6219a

lint

09df1ba

github-actions bot removed the waiting for update Pull requests or issues that require changes/comments before continuing label Jan 27, 2026

fehmer and others added 3 commits January 28, 2026 00:19

Merge branch 'master' into feature/data-table

050f9d5

a very hard fix

7f89292

cleanup

e791fa3

Miodec requested a review from Copilot January 28, 2026 20:44

github-actions bot added the waiting for review Pull requests that require a review before continuing label Jan 28, 2026

Copilot started reviewing on behalf of Miodec January 28, 2026 20:45 View session

Copilot AI reviewed Jan 28, 2026

View reviewed changes

fehmer and others added 5 commits January 31, 2026 14:57

fix type

f2a942a

allow complex headers with sorting

a59ed65

added tests

a4dbc97

copilot

1325ab3

Merge branch 'master' into feature/data-table

aa9c1e4

Miodec merged commit 8ab345d into master Feb 2, 2026
13 checks passed

Miodec deleted the feature/data-table branch February 2, 2026 11:37

Uh oh!

Conversation

fehmer commented Jan 20, 2026

Uh oh!

socket-security bot commented Jan 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jan 23, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Jan 27, 2026

Uh oh!

github-actions bot commented Jan 27, 2026

Uh oh!

github-actions bot commented Jan 27, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Comments

socket-security bot commented Jan 20, 2026 •

edited

Loading